microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
872 stars 479 forks source link

Add dataset to `SearchInvokeValue` #6693

Open kuojianlu opened 1 year ago

kuojianlu commented 1 year ago

Use this query to search for the most popular feature requests.

Is your feature request related to a problem? Please describe. For Adaptive Card dynamic search (example), dataset will be included in Activity.Value. For example, image

But dataset is not included in SearchInvokeValue. Is there any reason behind this design?

Describe the solution you'd like Add dataset to SearchInvokeValue. For example:

namespace Microsoft.Bot.Schema
{
    public class SearchInvokeValue
    {
        [JsonProperty("kind")]
        public string Kind { get; set; }

        [JsonProperty("queryText")]
        public string QueryText { get; set; }

        [JsonProperty("queryOptions")]
        public SearchInvokeOptions QueryOptions { get; set; }

        [JsonProperty("dataset")]
        public string Dataset { get; set; }

        [JsonProperty("context")]
        public object Context { get; set; }
    }
}

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.