microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
865 stars 480 forks source link

fix: [#6683] Timeout issue when using DLASE #6696

Closed sw-joelmut closed 9 months ago

sw-joelmut commented 9 months ago

Fixes #6683

Description

This PR fixes an issue where, while using DLASE, the bot threw a timeout issue while streaming, due to not generating a response in the initial request. Therefore, if the streaming process in the initial request takes longer than 15 seconds to finalize and generate a response, the bot will throw a timeout issue. Sending a response (HTTP 202 (Accepted)) before starting to process all streaming requests addressed the issue and will not generate a timeout issue.

Specific Changes

Testing

The following image shows the timeout issue before and after the fix.

Note: consistently was timing out around 25 to 35 activities, with the fix, it is no longer the case.

imagen

tracyboehrer commented 9 months ago

@sw-joelmut It appears some Microsoft.Bot.Connector.Streaming.Tests are failing.

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 371447


Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Connector.Streaming/Application/TimerAwaitable.cs 1 68.25%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 17 91.2%
<!-- Total: 20 -->
Totals Coverage Status
Change from base Build 369561: 0.004%
Covered Lines: 24147
Relevant Lines: 32873

💛 - Coveralls
BruceHaley commented 9 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll

sw-joelmut commented 9 months ago

@sw-joelmut It appears some Microsoft.Bot.Connector.Streaming.Tests are failing.

Changes applied, and updated the PR's description, thanks!