microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

865 stars 480 forks source link

Add sendx5c parameter to Certificate factory class #6699

Closed ceciliaavila closed 9 months ago

ceciliaavila commented 9 months ago

minor

Description

This PR adds the sendx5c parameter to the CertificateServiceClientCredentialsFactory and MsalAppCredentials classes.

Specific Changes

Added sendx5c parameter to the CertificateServiceClientCredentialsFactory class into a new constructor.
Added sendx5c parameter to the MsalAppCredentials class into a new constructor.
Updated CertificateServiceClientCredentialsFactoryTests to cover the new constructor.
Added MsalServiceClientCredentialsFactoryTests test class.

Testing

This image shows the new tests passing.

ceciliaavila commented 9 months ago

Converting to draft while reviewing #6694

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 372341

0 of 0 changed or added relevant lines in 0 files are covered.
48 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.06%) to 73.511%

Files with Coverage Reduction	New Missed Lines	%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs	1	90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs	1	90.91%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs	1	93.55%
/libraries/Microsoft.Bot.Connector/Authentication/MsalAppCredentials.cs	45	12.22%
<!--	Total:	48	-->

Totals
Change from base Build 371560:	0.06%
Covered Lines:	24174
Relevant Lines:	32885

💛 - Coveralls

BruceHaley commented 9 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll

ceciliaavila commented 9 months ago

Hi @tracyboehrer , we reverted the changes to CertificateServiceClientCredentialsFactory as they were addressed in #6694. We kept the changes to MsalAppCredentials and the new unit tests.