microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

865 stars 480 forks source link

Enable MSAL settings to save access token in cache #6706

Closed JhontSouth closed 7 months ago

JhontSouth commented 7 months ago

minor

Description

This PR adds the necessary MSAL settings to manage the cached access token value and not request a new value on each request.

Specific Changes

Added SetCacheOptions to the AppTokenCache of the ClientApplication in MsalAppCredentials class.

Testing

The following images show the interaction with the bot and the token values in every message.

tracyboehrer commented 7 months ago

@JhontSouth Appears to be failing in the Connector unit tests.

tracyboehrer commented 7 months ago

@JhontSouth We should check this in Node JS SDK too.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 378018

0 of 0 changed or added relevant lines in 0 files are covered.
45 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.007%) to 78.443%

Files with Coverage Reduction	New Missed Lines	%
/libraries/AdaptiveExpressions/LRUCache.cs	4	87.18%
/libraries/Microsoft.Bot.Connector/Authentication/MsalAppCredentials.cs	41	13.04%
<!--	Total:	45	-->

Totals
Change from base Build 378011:	-0.007%
Covered Lines:	26130
Relevant Lines:	33311

💛 - Coveralls

BruceHaley commented 7 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll