search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
872 stars 479 forks source link

fix: Disable failing expired token test in CloudAdapter #6707

Closed sw-joelmut closed 10 months ago

sw-joelmut commented 10 months ago

minor

Related https://github.com/microsoft/botbuilder-js/pull/4560

Description

This PR disables the ExpiredTokenShouldThrowUnauthorizedAccessException test due to invalid SigningKey value in the token. This will be skipped for now until a fix is provided, so it doesn't block new PR merges.

sw-joelmut commented 10 months ago

Hi @tracyboehrer

There is a unit test failing in main, preventing other PRs to pass. We created this PR to disable it temporarily until we provide a fix.

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 377855

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector/Authentication/JwtTokenExtractor.cs 2 53.85%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 3 89.81%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs 4 74.47%
/libraries/Microsoft.Bot.Connector/Authentication/JwtTokenValidation.cs 5 56.92%
/libraries/Microsoft.Bot.Connector/Authentication/EmulatorValidation.cs 13 32.35%
<!-- Total: 27 -->
Totals Coverage Status
Change from base Build 375403: -0.08%
Covered Lines: 26119
Relevant Lines: 33299
💛 - Coveralls