Closed sw-joelmut closed 10 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs | 1 | 90.91% | ||
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs | 1 | 90.91% | ||
/libraries/Microsoft.Bot.Builder.Dialogs/DialogExtensions.cs | 4 | 94.74% | ||
<!-- | Total: | 6 | --> |
Totals | |
---|---|
Change from base Build 377857: | 0.0% |
Covered Lines: | 26127 |
Relevant Lines: | 33309 |
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
minor
Description
This PR adds error detection when the internal
RunAsync
method fails usingAdaptiveDialogs
, otherwise, the originalException
gets lost.Specific Changes
try/catch
around theEmitEventAsync
when used in theInternalRunAsync
method. If there is an error, it will be captured and thrown as anAggregateException
containing the original and new error.Testing
The following image shows the pipeline working and how the error is thrown.