search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
864 stars 480 forks source link

feat: Add Ase channel validation. #6718

Closed fangyangci closed 6 months ago

fangyangci commented 6 months ago

Fixes #6719 JS PR #4589

Description

To resolve the connection issue between DL_ASE and bot, we built DL_ASE v2.0. In v2.0, we used WebSocket/HTTPS instead of named pipe to connect between DL_ASE and bot.

Therefore, we need to add a special header validation for AseChannel.

Specific Changes

Add AseChannel channelId check in ConfigurationBotFrameworkAuthentication.

Testing

Adding unit tests in JwtTokenValidationTests. Test locally with plulic/usgove singletenant/multitenant/umsi

fangyangci commented 6 months ago

For testing purposes, I need to merge pull request #6714. Once #6714 is merged into the main branch, this will be resolved.