microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
878 stars 484 forks source link

Fix a json serializer bug. #6722

Closed fangyangci closed 10 months ago

fangyangci commented 10 months ago

Fixes #6723

Description

The streamingSession is using System.Text.Json to Deserialize string. But, in libraries/Microsoft.Bot.Streaming/Payloads/Models/StreamDescription.cs (line 28), it using JsonProperty. So, all the StreamContent type property will be lost.

Specific Changes

Using Newtonsoft.Json Instead of System.Text.Json.

Testing

Test locally, with attachment transfer to bot by websocket.