fix: [#6697] Typing middleware not working as expected in teams as well as web chat channel

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

864 stars 480 forks source link

fix: [#6697] Typing middleware not working as expected in teams as well as web chat channel #6743

Closed JhontSouth closed 5 months ago

JhontSouth commented 5 months ago

Fixes #6697

Description

This PR allows showing the typing indicator before every message bot.

Specific Changes

Added ProcessTypingAsync method in ShowTypingMiddleware class.
Added StartTyping process to every activity iteration in the OnSendActivities method execution.

Testing

The following image shows the typing indicator being displayed between the different messages sent by the bot.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 384208

0 of 0 changed or added relevant lines in 0 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.001%) to 78.379%

Files with Coverage Reduction	New Missed Lines	%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs	1	93.55%
/libraries/Microsoft.Bot.Builder/ShowTypingMiddleware.cs	7	89.39%
<!--	Total:	8	-->

Totals
Change from base Build 384147:	0.001%
Covered Lines:	26174
Relevant Lines:	33394

💛 - Coveralls

BruceHaley commented 5 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll