microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
864 stars 480 forks source link

Fix LU parser rules to support all comments in a file #6744

Closed sw-joelmut closed 5 months ago

sw-joelmut commented 5 months ago

minor

Description

This PR updated the LU lexer and parser rules to support the case with a LU file with only comments in it.

Specific Changes

Testing

This image shows the unit tests passing after the changes. image

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 384362


Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 93.94%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 93.94%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 384324: 0.0%
Covered Lines: 26174
Relevant Lines: 33394

💛 - Coveralls