microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
878 stars 484 forks source link

Fix error when building activity with non-string text #6753

Closed ceciliaavila closed 8 months ago

ceciliaavila commented 9 months ago

minor

Related BF-Composer Issue: https://github.com/microsoft/BotFramework-Composer/issues/9692

Description

This PR adds a validation to avoid sending object values as the activity's text and speak. With this change, we are matching JS implementation.

Specific Changes

Testing

These images show how the property was displayed before and after the fix. image

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 385156

Details


Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 3 90.09%
/libraries/Microsoft.Bot.Builder/ActivityFactory.cs 12 89.1%
<!-- Total: 15 -->
Totals Coverage Status
Change from base Build 384727: 0.0%
Covered Lines: 26184
Relevant Lines: 33402

💛 - Coveralls
BruceHaley commented 9 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll