microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
864 stars 480 forks source link

fix: [#6746] Move SaveAllChanges method from SetProperty to OAuthInput #6757

Closed sw-joelmut closed 3 months ago

sw-joelmut commented 4 months ago

Fixes #6746

Description

This PR moves the SaveAllChanges functionality from the SetProperty and SetProperties classes to the OAuthInput class. Additionally, addressing the old issue (https://github.com/microsoft/BotFramework-Composer/issues/9533), that introduced this change.

Specific Changes

Testing

The following image shows an SSO bot working, retrieving the user's state after exchanging the token, correctly. image

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 385861

Details


Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SetProperty.cs 1 60.0%
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/OAuthInput.cs 32 52.21%
<!-- Total: 38 -->
Totals Coverage Status
Change from base Build 385734: 0.005%
Covered Lines: 26187
Relevant Lines: 33400

💛 - Coveralls