minor

Description

This PR updates the test projects, the test bots, and the CI pipelines to target .NET 8. All these changes need to be done in one PR for the build checks to pass. We divided the changes into three commits to ease the review:

Updated test projects (7c65b52b127903bd74e0871c781d3dc551230646)
Updated test bots (405c6fdccaa455007f68ce29fa82321257a9e0dd)
Updated CI yamls (ebbbf5d0433e58343d26acdeef3f2ca3c7cf5b8d)

Note: The FunctionalTests pipelines and the generators will be updated in separate PRs.

Specific Changes

For the test projects:
- Update projects to target net8.0 as well as net6.0.
- Removed any conditions considering frameworks lower than .NET5.
- Fixed CS8981 issue in Microsoft.Bot.Builder.Dialogs.Adaptive.Tests/ConditionalsTests
For the bots projects:
- Updated all the bots to target .NET8 instead of .NET6.
For the CI pipelines yamls:
- Added steps to build and test targeting .NET8.
- Removed steps to build and test targeting netcoreapp3.1.

Testing

This image shows the TestBot bots working as expected after the update.

Here we can see the CI pipeline working after the changes.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 389178

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.157%

Totals
Change from base Build 388884:	0.0%
Covered Lines:	26178
Relevant Lines:	33494

💛 - Coveralls

tracyboehrer commented 3 months ago

@ceciliaavila If it doesn't cause any issues, lets retain the 3.1 support in the packages.

ceciliaavila commented 3 months ago

@ceciliaavila If it doesn't cause any issues, lets retain the 3.1 support in the packages.

Sure, we'll update the projects to keep supporting netcoreapp 3.1.

tracyboehrer commented 2 months ago

@ceciliaavila @sw-joelmut Were the changes to retain 3.1 support (if possible) made?

sw-joelmut commented 2 months ago

Hi @tracy, we prioritized other issues over this, but we can address it next week.

tracyboehrer commented 2 months ago

[like] Tracy Boehrer reacted to your message:

From: Joel Mut @.> Sent: Friday, April 19, 2024 1:40:41 PM To: microsoft/botbuilder-dotnet @.> Cc: Tracy Boehrer @.>; Review requested @.> Subject: Re: [microsoft/botbuilder-dotnet] [#6741] Update projects to .Net 8 (PR #6760)

Hi @tracyhttps://github.com/tracy, we prioritized other issues over this, but we can address it next week.

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/botbuilder-dotnet/pull/6760#issuecomment-2066615132, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAH2HBV72KPUATVSI36I2N3Y6ENFTAVCNFSM6AAAAABEQNLLY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWGYYTKMJTGI. You are receiving this because your review was requested.Message ID: @.***>

BruceHaley commented 1 month ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll :heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

JhontSouth commented 1 month ago

Hi @tracyboehrer, the changes to maintain support for Net Core 3.1 are ready in the PR.

microsoft / botbuilder-dotnet

[#6741] Update projects to .Net 8 #6760