microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

864 stars 480 forks source link

feat: Support Single Tenant authentication through BotFramework-Emulator #6769

Closed JhontSouth closed 2 months ago

JhontSouth commented 3 months ago

minor

Description

This PR includes a dynamic way to validate the access token issuer value depending on the tenant ID used in Emulator.

Specific Changes

Added logic to validate the tid and issuer values to allow the Single Tenant authentication in EmulatorValidation.

Testing

The following image shows the Emulator working with a bot using Single Tenant authentication.

BruceHaley commented 3 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 387278

Details

0 of 0 changed or added relevant lines in 0 files are covered.
38 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 78.186%

Files with Coverage Reduction	New Missed Lines	%
/libraries/AdaptiveExpressions/LRUCache.cs	4	87.18%
/libraries/Microsoft.Bot.Connector/Authentication/EmulatorValidation.cs	34	30.14%
<!--	Total:	38	-->

Totals
Change from base Build 386500:	-0.02%
Covered Lines:	26182
Relevant Lines:	33487

💛 - Coveralls

tracyboehrer commented 1 month ago

@JhontSouth This will need to be done in JS too.

JhontSouth commented 1 month ago

@tracyboehrer https://github.com/microsoft/botbuilder-js/pull/4643