microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

864 stars 480 forks source link

fix: [#6752] The ShowTypingMiddleware throws System.ObjectDisposedException when an exception occurs in the bot #6772

Closed JhontSouth closed 2 months ago

JhontSouth commented 2 months ago

minor

Fixes # 6752

Description

This PR fixes the Dispose error avoiding the dispose of faulted tasks.

Specific Changes

Added if condition to dispose tasks that are not faulted.

Testing

The following image shows the bot responding correctly to other requests after an error has occurred.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 387573

Details

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 78.194%

Files with Coverage Reduction	New Missed Lines	%
/libraries/AdaptiveExpressions/LRUCache.cs	4	87.18%
<!--	Total:	4		-->

Totals
Change from base Build 386500:	-0.01%
Covered Lines:	26181
Relevant Lines:	33482

💛 - Coveralls

BruceHaley commented 2 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll