microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
864 stars 480 forks source link

Microsoft.Identity.Client bump #6779

Closed tracyboehrer closed 2 months ago

tracyboehrer commented 2 months ago

minor

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 388608

Details


Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector/Authentication/ManagedIdentityAuthenticator.cs 1 91.89%
/libraries/Microsoft.Bot.Builder/TokenResolver.cs 4 95.69%
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Templates/ActivityTemplate.cs 5 72.22%
/libraries/Microsoft.Bot.Builder/TranscriptLoggerMiddleware.cs 5 92.0%
/libraries/Microsoft.Bot.Builder/FileTranscriptLogger.cs 7 94.24%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/AdaptiveDialog.cs 48 88.79%
<!-- Total: 74 -->
Totals Coverage Status
Change from base Build 388195: -0.005%
Covered Lines: 26185
Relevant Lines: 33502

💛 - Coveralls
BruceHaley commented 2 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll :heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll :heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll

tracyboehrer commented 2 months ago

@sw-joelmut Most of the changes can be ignored. The newer package introduced some ambiguity because "Activity" was defined.

The real change is in ManagedIdentityAuthenticator.cs and corresponding tests. It would appear that the new Managed Identity client automatically retries for exceptions, and everything is now an exception. I didn't see a way to disable their retry. So effectively, this could would be trying max 20 times.