microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
878 stars 484 forks source link

fix: [#6792] Composer Bot with QnA Intent recognized triggers duplicate QnA queries #6793

Closed sw-joelmut closed 5 months ago

sw-joelmut commented 6 months ago

Fixes #6792

Description

This PR fixes an issue where QnA traces and requests to the CQA service were duplicated. This issue was related to how the QnA Intent recognized trigger is structured, it contains a TextInput and an Emit Custom Event. Both actions emit an "activityReceived" event, the first when an activity is received as a prompt response, and the second on purpose, which both execute the "recognized" functionality that triggers the duplication.

Specific Changes

Testing

The following image shows how it emits the double trace, and how it behaves after the fix. image

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 389235

Details


Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/AdaptiveDialog.cs 57 88.72%
<!-- Total: 61 -->
Totals Coverage Status
Change from base Build 389234: -0.009%
Covered Lines: 26184
Relevant Lines: 33498

💛 - Coveralls