microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
878 stars 484 forks source link

fix: Add Audience for Certificate auth to work with Skills #6794

Closed sw-joelmut closed 5 months ago

sw-joelmut commented 5 months ago

minor

Description

This PR adds Audience to CertificateAppCredentials, so it is passed correctly when calling a Skill bot. Additionally, these changes take into consideration the PR https://github.com/microsoft/botbuilder-dotnet/pull/6694, so the improvement isn't lost in the process.

Specific Changes

Testing

The following images show the new unit test passing and the Root + Skill bots working as expected. image image

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 389711

Details


Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 93.94%
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/Microsoft.Bot.Connector/Authentication/CertificateAppCredentials.cs 16 17.07%
<!-- Total: 22 -->
Totals Coverage Status
Change from base Build 389234: -0.004%
Covered Lines: 26192
Relevant Lines: 33506

💛 - Coveralls
BruceHaley commented 5 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll