Closed sw-joelmut closed 5 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs | 1 | 90.91% | ||
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs | 1 | 93.94% | ||
/libraries/AdaptiveExpressions/LRUCache.cs | 4 | 87.18% | ||
/libraries/Microsoft.Bot.Connector/Authentication/CertificateAppCredentials.cs | 16 | 17.07% | ||
<!-- | Total: | 22 | --> |
Totals | |
---|---|
Change from base Build 389234: | -0.004% |
Covered Lines: | 26192 |
Relevant Lines: | 33506 |
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll
minor
Description
This PR adds Audience to CertificateAppCredentials, so it is passed correctly when calling a Skill bot. Additionally, these changes take into consideration the PR https://github.com/microsoft/botbuilder-dotnet/pull/6694, so the improvement isn't lost in the process.
Specific Changes
oAuthScope
parameter tolibraries/Microsoft.Bot.Connector/Authentication/CertificateAppCredentials.cs
.libraries/Microsoft.Bot.Connector/Authentication/CertificateServiceClientCredentialsFactory.cs
by reverting the changes made in the PR https://github.com/microsoft/botbuilder-dotnet/pull/6694, but maintaining the improvement.CertificateAppCredentials
per Audience, instead of having just one with the defaultapi.botframework
.Testing
The following images show the new unit test passing and the Root + Skill bots working as expected.