microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

878 stars 484 forks source link

[#6825] Update Threading.Analyzers #6834

Closed sw-joelmut closed 3 months ago

sw-joelmut commented 3 months ago

Addresses #6825

minor

Description

This PR updates the Microsoft.VisualStudio.Threading.Analyzers from 15.8.122 to 17.10.48, and fixes the VSTHRD200 issue with internal methods.

Specific Changes

Updated Microsoft.VisualStudio.Threading.Analyzers to latest version in BotBuilder and VSIX projects.
Updated some internal methods that required the Async suffix due to the VSTHRD200 error alert.

Testing

The following image shows the CI pipeline working, and an echo bot generated with VSIX templates.

BruceHaley commented 3 months ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll