search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
878 stars 484 forks source link

TeamsInfo.SendMessageToTeamsChannelAsync relies on old adapter #6842

Closed tracyboehrer closed 2 months ago

tracyboehrer commented 3 months ago 
            await ((BotFrameworkAdapter)turnContext.Adapter).CreateConversationAsync(
tracyboehrer commented 3 months ago

@sw-joelmut This may not be a bug. Confusing though. I suspect that method is only called by a bot using the old adapter?

ceciliaavila commented 2 months ago

Hi @tracyboehrer, there are two SendMessageToTeamsChannelAsync methods, one for each adapter. The only difference is that the one for BotFrameworkAdapter needs the MicrosoftAppCredentials parameter, while the one for CloudAdapter only requires the appId. image

tracyboehrer commented 2 months ago

[like] Tracy Boehrer reacted to your message:

From: Cecilia Avila @.> Sent: Tuesday, September 3, 2024 7:15:04 PM To: microsoft/botbuilder-dotnet @.> Cc: Mention @.>; Author @.>; Comment @.***> Subject: Re: [microsoft/botbuilder-dotnet] TeamsInfo.SendMessageToTeamsChannelAsync relies on old adapter (Issue #6842)

Hi @tracyboehrerhttps://github.com/tracyboehrer, there are two SendMessageToTeamsChannelAsync methods, one for each adapter. The only difference is that the one for BotFrameworkAdapter needs the MicrosoftAppCredentials parameter, while the one for CloudAdapter only requires the appId. image.png (view on web)https://github.com/user-attachments/assets/ddda42c2-d8ba-45e9-b9a7-f67427e84613

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/botbuilder-dotnet/issues/6842#issuecomment-2327240020 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAH2HBXSEZ2BDDJOTODRDUDZUYDDTBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVE4DAMJQGQ3TIMBSURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UMRSG4YTMNJQGY3THJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOKIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVEYTCNZQGIYTMNZQQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRSGQ3TIMRWGAYTCOECUR2HS4DFUVWGCYTFNSSXMYLMOVS2SOBQGEYDINZUGAZIFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIZDENZRGY2TANRXGOTXI4TJM5TWK4VGMNZGKYLUMU. You are receiving this email because you were mentioned.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ceciliaavila commented 2 months ago

Hi @tracyboehrer, can we close this issue?

tracyboehrer commented 2 months ago

[like] Tracy Boehrer reacted to your message:

From: Cecilia Avila @.> Sent: Tuesday, September 10, 2024 11:59:39 AM To: microsoft/botbuilder-dotnet @.> Cc: Mention @.>; Author @.>; Comment @.***> Subject: Re: [microsoft/botbuilder-dotnet] TeamsInfo.SendMessageToTeamsChannelAsync relies on old adapter (Issue #6842)

Hi @tracyboehrerhttps://github.com/tracyboehrer, can we close this issue?

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/botbuilder-dotnet/issues/6842#issuecomment-2340480508 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAH2HBXO4AFPQEPJYN7EOU3ZV3NKXBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVE4DAMJQGQ3TIMBSURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UMRSG4YTMNJQGY3THJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOKIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVEYTCNZQGIYTMNZQQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRSGQ3TIMRWGAYTCOECUR2HS4DFUVWGCYTFNSSXMYLMOVS2SOBQGEYDINZUGAZIFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIZDENZRGY2TANRXGOTXI4TJM5TWK4VGMNZGKYLUMU. You are receiving this email because you were mentioned.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ceciliaavila commented 2 months ago

Closing as there's no issue. There are two methods, one for each adapter.