microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

872 stars 482 forks source link

fix: Disable telemetry adaptive sampling #6849

Closed JhontSouth closed 1 month ago

JhontSouth commented 1 month ago

minor

Description

This PR disables the adaptive sampling used in the telemetry client to avoid skipping logs due to big amount of concurrent users and events.

Specific Changes

Set to false property EnableAdaptiveSampling of telemetry settings in ServiceCollectionExtensions classes.

Testing

The following image shows the logs saved correctly in the Application Insights resource.

BruceHaley commented 1 month ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll