microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
872 stars 482 forks source link

[#6771] Fix Attachment issue when it has a MemoryStream instance #6850

Closed sw-joelmut closed 1 month ago

sw-joelmut commented 1 month ago

Fixes #6771

Description

This PR fixes an issue with DLASE when a MemoryStream instance is being used as an Activity.Attachment, e.g. a file. The ReadTimeout issue is caused when trying to serialize the non-serializable MemoryStream instance.

Specific Changes

Testing

The following images show the bot working, and the unit tests passing. image image

sw-joelmut commented 1 month ago

Im looking at the failing tests

BruceHaley commented 1 month ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll