search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
878 stars 484 forks source link

Add obsolete tag to MsalServiceClientCredentialsFactory class #6866

Closed ceciliaavila closed 2 weeks ago

ceciliaavila commented 2 weeks ago

minor

Description

This PR adds the obsolete tag to the MsalServiceClientCredentialsFactory class, so users opt to use one of the other factory classes depending on the type of authentication they use (ConfigurationServiceClientCredentialFactory, CertificateServiceClientCredentialsFactory, FederatedServiceClientCredentialsFactory, etc).

Specific Changes

Testing

This image shows the obsolete tag added to the class. image

ceciliaavila commented 2 weeks ago

Hi @tracyboehrer, this PR and a few others are failing with an error related to the private nuget feed. Let us know if there's anything we can do to help getting these merged.