microsoft / botbuilder-js

Welcome to the Bot Framework SDK for JavaScript repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using JavaScript.
https://github.com/Microsoft/botframework
MIT License
684 stars 279 forks source link

Skype is not sending the attachment details along with request object in group chats #4652

Open Ragu27ag opened 7 months ago

Ragu27ag commented 7 months ago

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

What package version of the SDK are you using.

Describe the bug

I am working on a skype bot built using bot framework sdk using node.js . The issue is when the user is posting any image in the group chat where bot is part of the group and if the user is attaching the image along with bot mention for eg : <-the image-> @sample_bot , only the bot mention is getting received in the bot backend and the attachment related things are not received in the request object.I need the attachment details for parsing the image

To Reproduce

Steps to reproduce the behavior:

  1. Go to skype group chat where bot is part of it
  2. attach an image in the chat box along with bot mention as we are sending this to the bot
  3. check the log after sending this message

Expected behavior

we wont be having any image related details in the request object in the log

tempsnip

Ragu27ag commented 6 months ago

Any update on this issue?

Ragu27ag commented 6 months ago

@tracyboehrer is there any update on this issue?

tracyboehrer commented 6 months ago

@Ragu27ag Concerning "...not received in the request object.I need the attachment details for parsing the image"

I assume you mean the incoming Activity? Can you provide what you are receiving?

Ragu27ag commented 6 months ago

@tracyboehrer If I send the image in a group chat where bot is a participant along with bot mention to specifically send to the bot

sssht

I am receiving this in the request body

obj2

Here the image related details such as content url is not getting received if i send to the bot from a group.

If image is sent directly to the bot instead of sending image from the group its working fine.

botdirect

But i need to send image from the group.

Ragu27ag commented 6 months ago

@tracyboehrer any update for this issue?

sw-joelmut commented 6 months ago

Hi @Ragu27ag and @tracyboehrer,

We reproduced the issue, happening in both JS and .NET bots. Inspecting how Skype sends messages to the bot and what it receives, the problem isn't related to BotBuilder SDK, as it receives the information from the Azure bot service (ABS). What seems to be happening is that Skype sends two separate messages, one for the image and one for the mention; the mention is the only one sent to the bot, whereas the image is sent just to the group (as this message doesn't contain any mention whatsoever). Either this way isn't supported by ABS, or Skype just sends the "mention" message without the image. image

ceciliaavila commented 1 month ago

@tracyboehrer, this issue can be closed, it's not a problem in the SDK. Thanks!