search

microsoft / botbuilder-js

Welcome to the Bot Framework SDK for JavaScript repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using JavaScript.
https://github.com/Microsoft/botframework
MIT License
684 stars 279 forks source link

ShowTypingMiddleware missing await on adapter.send #645

Closed johnataylor closed 5 years ago

johnataylor commented 5 years ago

bot.builder.core 4.1.5

await missing in callback implementation:

https://github.com/Microsoft/botbuilder-js/blob/master/libraries/botbuilder-core/src/showTypingMiddleware.ts#L75

(this is being sent from a timer callback, so maybe this is harmless?)

there is more implementation below it... is this redundant?

sgellock commented 5 years ago

pulling back into 4.2

benbrown commented 5 years ago

I think this IS harmless, since we don't really need to block on the typing activity having been sent before ... waiting to send another one for a few seconds. But it doesn't HURT either...