microsoft / botbuilder-python

The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.
http://botframework.com
MIT License
718 stars 286 forks source link

[PORT] Fix LuisRecognizer to not return intents if there is no utterance #1159

Closed tomlm closed 2 years ago

tomlm commented 4 years ago

Port this change from botbuilder-dotnet/master branch: https://github.com/microsoft/botbuilder-dotnet/pull/4129

Fixes #4117

Description

Luis Recognizer returns an intent of string.empty with a perfect score of 1.0. This messes up logic downstream in RecognizerSet because it thinks it has a perfect intent.

Specific Changes

Testing

Changed RegexRecognizer to behave just like LuisRecognizer so that ValueRecognizer tests are valid check.

Changed projects

Adityagrao commented 4 years ago

Added PR for the same #1387