microsoft / botbuilder-python

The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.
http://botframework.com
MIT License
710 stars 280 forks source link

Carousel not rendering adaptive cards in full width #1843

Closed RobinVds closed 9 months ago

RobinVds commented 2 years ago

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

botbuilder-ai==4.14.0 botbuilder-azure==4.14.0 botbuilder-core==4.14.0 botbuilder-dialogs==16 botbuilder-integration-aiohttp==4.14.0 botbuilder-schema==4.14.0 botbuilder-testing==4.14.0 botframework-connector==4.14.0 botframework-streaming==4.14.0

Describe the bug

When I render my adaptive cards in a carousel the cards are decreased in width. When I try to use msteam { "width": "full"}, nothing changes.

To Reproduce

Render adaptive cards in a carousel in the web app.

Expected behavior

The cards in the carousel have the same width as when rendered outside of the carousel.

Screenshots

image

Additional context

Issue seems to be ok in desktop app

axelsrz commented 2 years ago

Hello @RobinVds could you confirm if you are experiencing this in Teams (web) or in a regular webchat app?

RobinVds commented 2 years ago

Until yesterday I was only experiencing this in the web client. Today it suddenly is the same for both the webclient as the normal teams app (downloaded).

So I'm experiencing it in the teams web client and the teams desktop app.

axelsrz commented 2 years ago

Hello @clearab this looks like a teams rendering issue, could you chime in?

clearab commented 2 years ago

I've reached out to them. @RobinVds for future reference please use one of the methods outlined here for Teams-specific issues: https://docs.microsoft.com/en-us/microsoftteams/platform/feedback

RobinVds commented 2 years ago

@clearab thanks for pointing me to that page. I expected it to be an issue related to python. If I understood your message correctly you have already created an issue somewhere for this? If so, is there a way for me to track this?

clearab commented 2 years ago

The Teams group is currently investigating - either they or I will follow up on this thread when we have a more concrete answer.

RobinVds commented 2 years ago

@clearab do you think I could get some kind of indication if this is going to be a matter of days/weeks/months/... as we are using the carousel in our production app and it is just not presentable to clients in this way.

clearab commented 2 years ago

The Teams group have repro'd the issue, and are working on solutions. I can only provide a rough estimate for a fix currently - the global roll-out of a solution should be sometime in Q1 of 2022.

RobinVds commented 2 years ago

Any updates on this?

Meghana-MSFT commented 2 years ago

This issue has been fixed and we have verified the fix. Attaching a screenshot of carousel cards with and without full width. Could you please check once and confirm the fix?

image