search

microsoft / botbuilder-python

The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.
http://botframework.com
MIT License
700 stars 280 forks source link

German language is not appropiate used when using Confirmprompts #1882

Closed PascalHessler closed 2 years ago

PascalHessler commented 2 years ago

The Issue

I am building a chatbot for german users. I am sending the local "de-de" as user, and can confirm this actual arrives the bot. When i want to use Confirmprompts the bot returns Yes and No and not "Ja" "Nein".

The Solution

After a lot of digging, I found the underlying cause and a fix. The culture model does not actually recognices German (de-de) as supported language, and thus switches to the default (english). But in the prompt_culture_models.py German actualy exists and ther is a todo "# TODO: Replace with Culture.German after Recognizers-Text package updates." Which I looked up and the Recognizers-Text package sis already updated :) . Still this is not the real issue.

The reason is that german is not listed in the supported cultures function. I simply added it and every thing works fine.

@classmethod def get_supported_cultures(cls) -> List[PromptCultureModel]: """ Gets a list of the supported culture models. """ return [ cls.Chinese, cls.German, cls.Dutch, cls.English, cls.French, cls.Italian, cls.Japanese, cls.Korean, cls.Portuguese, cls.Spanish, cls.Turkish, ]

InfinytRam commented 2 years ago

Hi @PascalHessler -- thanks, looking into this issue.

msomanathan commented 2 years ago

@PascalHessler There is a PR which will fix this issue. Thanks, @ramfattah for the PR!