search

microsoft / botbuilder-python

The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.
http://botframework.com
MIT License
706 stars 280 forks source link

Some fixes have not been correctly released on pip #1938

Closed ThibaultDieudonne closed 2 years ago

ThibaultDieudonne commented 2 years ago

After installing botbuilder-core last release from pip, I had the exact error described and fixed in the issue #1880. It appears that the telemetry_logger_middleware.py file hasn't been updated in pip. It can easily be checked by installing botbuilder-core with pip, then in botbuilder/core/telemetry_logger_middleware.py L220 should be "if activity.attachments and len(activity.attachments) > 0:" instead of "if activity.attachments and activity.attachments.strip():". Would appreciate if you could update the pip repository.

anishprasad01 commented 2 years ago

Hi @ThibaultDieudonne,

It's not that it hasn't been updated correctly, but rather that it hasn't been released yet. PR #1888 containing the fix was merged into main on January 28th, 2022, but the last release of the Python SDK, 4.14.1, was published on January 4th, 2022.

Until such a time as a new Python SDK version is released, you can clone the fix from main and use it in your bot.