Closed sarhaang closed 1 week ago
Ya. This is a bug. Looks to be missing the equivalent implementation as JS and DotNet SDK's, or even the 'exchange_token' on CloudAdapter as the Python BotFrameworkAdapter has.
Correction notes:
OAuthPrompt, block starting at line 480 (mentioned above) should likely be removed. This appears to be code for the original implementation. The 'else' statement matches DotNet which uses a UserTokenAccess object to make the correct call for new vs old adapter.
However, UserTokenAccess should be reviewed, especially around TurnState having had a UserTokenClient set.
Version
Installed using instructions 'Using the SDK locally` in README
Describe the bug
SSO for singe tenant with Cloud Adapter does not work in Teams web/desktop client. Works in Web Chat.
To Reproduce
Steps to reproduce the behavior:
https://learn.microsoft.com/en-us/microsoftteams/platform/sbs-bots-with-sso?source=recommendations&tabs=ngrok&tutorial-step=4
Expected behavior
SSO was working as of last week but is not working anymore. There was a bot infra outage a few days ago that caused an error when uploading
manifest.json
on the web/desktop app. Could it be related to that?Additional context
Fails here:
in
botbuilder-python/libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/oauth_prompt.py