Error while trying to use JwtTokenValidation.authenticate_request

Loprock commented 1 month ago

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

botbuilder-schema==4.11.0 botframework-connector==4.11.0

Describe the bug

Using python. After using the following request 'JwtTokenValidation.authenticate_request' we started getting the error: [Errno Unauthorized. Invalid AppId passed on token: ] b****-4-4-8-a*** this issue started occurring from ~March 2024

To Reproduce

Steps to reproduce the behavior: the whole flow is represented in the code snippet. after the main init we try to setup a webhook which is failing

Expected behavior

we want the auth to get approved and manage to communicate

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

adding a code snippet to show the flow (only relevant for this issue)

 class MicrosoftTeamsMainloop(FrameworkMainloop):
    def __init__(self, config):
        super().__init__(config)
        self.client = MicrosoftTeamsClient(config.bot_id, config.app_password)
        self.user_cache = TeamsUsersCache(self.client)
        self.app = Flask(__name__)
        self.setup_webhook_app()
        self._maybe_setup_global_proxy_for_process()

    def setup_webhook_app(self):
        @self.app.route("/", methods=["POST"])
        def webhook():
            # pass on the flask global request object
            return self.handle_post(request)

    def authenticate_webhook(self, current_request: Request, activity: Activity):
        logger = get_algobot_logger()
        loop = asyncio.new_event_loop()
        try:
            loop.run_until_complete(
                JwtTokenValidation.authenticate_request(
                    activity,
                    current_request.headers.get("Authorization"),
                    self.credential_provider,
                )
            )
            return True
        except Exception as e:
            logger.error('exception {} thrown while trying to authenticate webhook.'.format(e))
            return False
        finally:
            loop.close()

tracyboehrer commented 1 month ago

@Loprock That error indicates the token the bot received does not contain the correct audience claim. The expectation is that the audience claim matches the bots AppId. Is 4.11.0 correct? That was released in Nov 2020. If accurate, this is ually because the config for the bot is wrong.