Fixed type hint in turn_context.py

microsoft / botbuilder-python

The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.

http://botframework.com

MIT License

712 stars 285 forks source link

Fixed type hint in turn_context.py #2147

Closed Nikita-Gz closed 2 months ago

Nikita-Gz commented 3 months ago

Previous type hint implied that send_activity in turn_context.py will always return ResourceResponse, meanwhile it can also return None

Fixes #2146

Description

The type hint is fixed to include possible None return, otherwise it might make the developers assume that there is no need to check for None.

Specific Changes

Changed ResourceResponse to Union[ResourceResponse, None] type hint

Nikita-Gz commented 2 months ago

"BotBuilder-Python-CI-PR-yaml" step seems to be waiting for something. Do you know what that step is about @tracyboehrer ? I can't seem to find its definition