Intermittently Missing User Name in turn_context's activity.from_property

[qneville]

Version

botbuilder-core 4.16.1

Describe the bug

When a user interacts with a button, we receive an inconsistent result in our turn_context returned from Microsoft. To debug this, we've been logging from_property results. There are several instances of matching aad_object_id where one line will have a name present, and one will not.

My temporary workaround was to wrap all our calls to activity.from_property.name in this function because occasionally a username will come back None, and not be defined in from_property.

def get_username_from_context(turn_context):
    fallback = "A Team Member"
    teams_username = turn_context.activity.from_property.name
    name = teams_username if teams_username else fallback
    return name

Expected (output from print(turn_context):

{'additional_properties': {}, 'id': '29:1PqtMqQTPxxxxxxxxxxxxxxxxxYyzHIkq3OW69T-A', 'name': 'Guy Who Clicked A Thing', 'aad_object_id': 'fd0b1f02-xxxx-xxxx-xxxx-f6fb9b071369', 'role': None}

Received (Occasionally):

{'additional_properties': {}, 'id': '29:1PqtMqQTPxxxxxxxxxxxxxxxxxYyzHIkq3OW69T-A', 'name': None, 'aad_object_id': 'fd0b1f02-xxxx-xxxx-xxxx-f6fb9b071369', 'role': None}

To Reproduce

(Simplified for brevity) Add to the actions array of an adaptive card template being posted to the channel.

{
            "type": "Action.Submit",
            "title": "Click me!",
            "data": {
                "msteams": {
                    "type": "invoke",
                    "value": {
                        "option": "click-me"
                    }
                }
            }
        },

Accepting the interaction (in bot.py):

async def on_invoke_activity(self, turn_context):
            name = turn_context.activity.from_property.name   # May or may not be None
            print(turn_context.activity.from_property)                  # Will show something like the above output examples

[stevkan]

@qneville - Thank you for your patience. Are you still experiencing an issue with this? If so,

• Is this a new problem that has only recently surfaced?
• Has there been any changes to your code or updates?
• Was the version of the SDK updated recently and did this issue surfacing correspond to the update?
• Which client is used for interacting with the bot (e.g. Web Chat, Facebook, Slack, etc.)?

[stevkan]

Closing due to inactivity. Please feel free to reopen if the issue persists or you have new details to share.