microsoft / botbuilder-python

The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.

http://botframework.com

MIT License

712 stars 285 forks source link

aiohttp 3.10.2 #2158

Closed gandiddi closed 2 months ago

gandiddi commented 2 months ago

minor

Updates aiohttp from 3.9.5 to 3.10.2

https://github.com/microsoft/botbuilder-python/pull/2152

tracyboehrer commented 2 months ago

Failing PyLint with:

***** Module botbuilder-adapters-slack.botbuilder.adapters.slack.slack_client libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py:420:8: E1701: Async context manager 'NoneType' doesn't implement aenter and aexit. (not-async-context-manager)

gandiddi commented 2 months ago

Failing PyLint with:

***** Module botbuilder-adapters-slack.botbuilder.adapters.slack.slack_client libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py:420:8: E1701: Async context manager 'NoneType' doesn't implement aenter and aexit. (not-async-context-manager)

@tracyboehrer , I have verified pylint with both Python 3.10.11 and 3.9.13 and am not encountering the specified error locally. I am seeing the same results with and without the PR changes (the aiohttp version update in setup.py), as shown in the screenshot below.