search

microsoft / botbuilder-tools

Welcome to the Bot Framework Tools repository, which is the home for a set of tools for developers building bots with the Microsoft Bot Framework
https://github.com/Microsoft/botframework
MIT License
444 stars 262 forks source link

Dispatch Test Report Linking to Wrong Version #1372

Closed henryjenkins closed 5 years ago

henryjenkins commented 5 years ago

Tool

Name: Dispatch Version: 1.5.8 OS: MacOS 10.14.6 (Mojave)

Describe the bug

We use a build pipeline to manage LUIS and Dispatch. This includes generating a new version of the Dispatch model. When we run batch tests against the model, the resulting report (Summary.html) always contains a link to .../versions/Dispatch... rather than the actual version e.g. .../versions/39...

To Reproduce

Steps to reproduce the behavior:

  1. Create 2 or more LUIS models
  2. Create a dispatch model from those LUIS models, the default version is always Dispatch
  3. Run dispatch refresh and specifiy a new version (e.g. dispatch refresh --version 39
  4. Run a batch test using the dispatch test batch testing tool

Expected behavior

The links in the report ("View in LUIS portal" at the top right of the page, and "LUIS Application ID: [UUID]" in the blue banner) always link to version "Dispatch" rather than the actual version.

It is expected the links will use the correct version, as specified in the .dispatch file. The batch test and resulting report otherwise bahave as expected as far as I can tell.

Screenshots

The two links as reported above:

Screenshot 2019-11-14 at 12 31 24

[bug]

dmvtech commented 5 years ago

@henryjenkins I will attempt to see if I can reproduce. I see that dispatch v1.5.9 is out. Is it possible for you to see if you can reproduce with that version?

dmvtech commented 5 years ago

I am able to reproduce this. (Windows 10, dispatch v1.5.9)

@tsuwandy I'm guessing this is just a small bug in the tool that creates the html/link.

tsuwandy commented 5 years ago

@henryjenkins, nice catch! I have fixed this and will try to publish latest version by tomorrow (v 1.6.0). Thanks.

tsuwandy commented 5 years ago

@henryjenkins, dispatch 1.6.0 is published to npm. Closing this, please reopen if issue persists. Thanks!

henryjenkins commented 5 years ago

Hi. I'm just catching up on things. When I run tests now, with v1.6.0, I see no version at all in the URL.

.../versions//dashboard

tsuwandy commented 5 years ago

@henryjenkins, great catch again, thanks! This will be fixed with v 1.6.1 to be published later today.

henryjenkins commented 5 years ago

This still seems to be a problem with Dispatch v1.6.1

tsuwandy commented 5 years ago

@henryjenkins, got it. It's the summary file in the test folder and also after running "eval" command if the version is specified (non Dispatch version). I have updated the code and will deploy with the next batches of improvements/other bug fixes. Thanks!

henryjenkins commented 5 years ago

Ah! Of course! I was so busy focusing on the report in the test folder that I forgot about the summary file at root level. I'd had been more specific if I'd realised. Thanks.

tsuwandy commented 5 years ago

@henryjenkins, Dispatch 1.6.2 is published to npmjs and should fix this issue. Thanks!