search

microsoft / botframework-components

The repository for components built by Microsoft for the Azure Bot Framework.
https://aka.ms/botdocs
MIT License
112 stars 82 forks source link

Calendar Skill sending 'BadRequest' error message #1332

Closed bensonjm closed 2 years ago

bensonjm commented 2 years ago

Describe the bug

The Calendar Skill sends a 'BadRequest' message after sending a list of users it found. This error is shown in the Emulator

Version

Version: 2.1.2 Electron: 8.2.4 Chrome: 80.0.3987.165 NodeJS: 12.13.0 V8: 8.0.426.27-electron.0

To Reproduce

  1. Create the Enterprise Assistant with Calendar and People Skills
  2. Use the emulator to test it.
  3. Create an event e.g. 'Set up a meeting for tomorrow at 9 AM'
  4. Add a title
  5. When it asks who it should invite give a name that has multiple entries e.g. John
  6. It will return a list of entries for since it's not able to find a unique user
  7. See error

Expected behavior

Emulator should not throw the error

Screenshots

image
InfinytRam commented 2 years ago

investigating.

InfinytRam commented 2 years ago

Hi @bensonjm

Update: I'm able to reproduce this issue.

image

lauren-mills commented 2 years ago

I was able to capture the full error and it looks like this is related to https://github.com/microsoft/botbuilder-dotnet/issues/6307

ReasonPhrase:"Bad Request" Content:"{"errors":{"value.conversation.DialogState.dialogStack[0].state._adaptive.actions[0].dialogStack[0].state._adaptive.actions[0].dialogStack[0].state._adaptive.actions[0].dialogStack[0].state._adaptive.actions[0].dialogStack[0].state.options.choices.value":["The reader's MaxDepth of 32 has been exceeded. Path 'value.conversation.DialogState.dialogStack[0].state._adaptive.actions[0].dialogStack[0].state._adaptive.actions[0].dialogStack[0].state._adaptive.actions[0].dialogStack[0].state._adaptive.actions[0].dialogStack[0].state.options.choices', line 1, position 24486."]},"type":"https://tools.ietf.org/html/rfc7231#section-6.5.1","title":"One or more validation errors occurred.","status":400,"traceId":"|34ab37e9-46a6f1392d5c683f.4.163261314.34ab37f2"}"

lauren-mills commented 2 years ago

Following up with the SDK team to resolve this at the SDK level.

ryub3n commented 2 years ago

@lauren-mills - It's probably related to the SDK but the strange thing is I don't see this error once it's published.

EricDahlvang commented 2 years ago

The Bot Builder SDK uses Newtonsoft v12. The reader's MaxDepth of 32 has been exceeded is from Newtonsoft > v12.

InfinytRam commented 2 years ago

See also: https://github.com/microsoft/BotFramework-Composer/issues/9208

devbynight commented 2 years ago

it seems the error is because List card is no longer supported. Reference this and this

tracyboehrer commented 2 years ago

The MaxDepth should be resolved in the 4.17 release we published last week. The default depth is now 128.

johnataylor commented 2 years ago

@bensonjm are you still running into this issue with the 4.17 release?