search

microsoft / botframework-components

The repository for components built by Microsoft for the Azure Bot Framework.
https://aka.ms/botdocs
MIT License
112 stars 80 forks source link

Generators: Schema files are called sdk.schema and it should be app.schema #781

Open tomlm opened 3 years ago

tomlm commented 3 years ago

Describe the bug

Composer is still creating the wrong file name for schema. It should not be called SDK.schema because it's the application schema.

Version

1.4.rc2

Browser

OS

To Reproduce

Create project, look in the schemas folder, it's sdk.schema. That is a mistake we keep propagating because nobody is taking responsibility for change the name of the damn thing. I have been filing this bug since v1.0 and we are 4 releases later and nobody has changed the name.

Expected behavior

It should be app.schema.

Screenshots

Additional context

cwhitten commented 3 years ago

@benbrown heads up - can you make sure this gets into the runtime templates on the new creation side?

peterinnesmsft commented 3 years ago

Need to evaluate where this change will impact and ensure no unintended regression. Will pick this up in R14.

tracyboehrer commented 3 years ago

Including update-schema scripts in generators and skills.

ryanisgrig commented 3 years ago

Per @cwhitten:

Composer currently accepts both app.schema/uischema & sdk.schema/uischema, with "app" taking priority.