Greeting isn't greeting

microsoft / botframework-components

The repository for components built by Microsoft for the Azure Bot Framework.

https://aka.ms/botdocs

MIT License

112 stars 82 forks source link

Greeting isn't greeting #909

Open clearab opened 3 years ago

clearab commented 3 years ago

In all our generators we use the mis-labelled "Greeting" trigger to trigger our welcome/greeting dialogs. Unfortunately, this isn't actually a Greeting trigger, it fires on all ConversationUpdate Activities (which includes a lot more than membersAdded events). We need to add testing of the type of ConversationUpdate to all of these, and only do the greeting for the membersAdded type.

clearab commented 3 years ago

ryanisgrig commented 3 years ago