Action.execute (AC 1.4) support

microsoft / botframework-sdk

Bot Framework provides the most comprehensive experience for building conversation applications.

MIT License

7.48k stars 2.44k forks source link

Action.execute (AC 1.4) support #6182

Open clearab opened 3 years ago

clearab commented 3 years ago

Add support for the Action.Execute command and various flows, including the action/execute invoke and auth flows in both the activity handler and adaptive triggers.

OBI spec is here: https://github.com/microsoft/botframework-obi/pull/128

Hacked up webchat that can do AC 1.4 cards: https://github.com/clearab/CateringDemo

Tracking Status

Dotnet SDK Issue

[x] PR
[x] Merged

Javascript SDK Issue

[X] PR
[X] Merged

Python SDK Issue

[X] PR
[x] Merged

Java SDK Issue

[x] PR
[x] Merged

**Docs

[x] PR
[x] Merged

clearab commented 3 years ago

Existing documentation (based on the JSON payloads) https://docs.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/cards/universal-actions-for-adaptive-cards/overview?tabs=mobile

mdrichardson commented 3 years ago

@JonathanFingold We're merged in all SDKs for this one. Do you need to do anything with Docs for this?

JonathanFingold commented 3 years ago

@mdrichardson @clearab - I'll need a recommended approach to building bots that support this feature, and actionable messages in particular, for both SDK-first bots and Composer bots. (Adding @kaerm )

On the SDK side, it would seems like an activity handler bot without dialogs would make sense, at least for less complicated bots.
On the Composer side, I'm guessing custom middleware or a custom channel/connection would make sense, but would not be easy.

JonathanFingold commented 3 years ago

PS. Will the protocol doc get copied to the botframework-sdk repo and be public?

clearab commented 3 years ago

I'm going to create some work items for creating (porting really) a sample, as well as documenting. Its in a bit of an odd space, as lots of our partners are documenting this for channel-specific implementations.

clearab commented 3 years ago

I'll leave this open though, and associate those new items back.

mdrichardson commented 3 years ago

@clearab I just noticed that none of the merged PRs for this add triggers for Adaptive, at least as far as I can tell. I came into this one after just about everything was already merged--can you verify that:

~~1) We want adaptive triggers for this, and~~ ~~2) If we do, we don't already have them~~

~~I feel like this issue is much bigger than I originally understood (adaptive triggers, auth) and could use a second set of eyes to verify where this one is actually at~~

mdrichardson commented 3 years ago

@clearab Disregard last. I found it in Components/AdaptiveCards