microsoft / botframework-sdk

Bot Framework provides the most comprehensive experience for building conversation applications.
MIT License
7.5k stars 2.44k forks source link

[SDK/Service] OAuthPrompt should complete with null token and error when a signin flow is cancelled #6216

Open swagatmishra2007 opened 3 years ago

swagatmishra2007 commented 3 years ago

Issue

Today when a bot user clicks the login button on an oauth card , the signin process involves opening a browser for login. If the user cancels this flow (by not granting consent for instance), or other failure, the flow fails in the browser and the bot is never notified. For an example see issue - https://github.com/microsoft/botframework-sdk/issues/6137

Proposed change

Component Impact

Customer Impact

More seamless flow in case of user login failure (See referred issue above)

Tracking Status

Dotnet SDK [TODO]()

Javascript SDK [TODO]()

Python SDK [TODO]()

Java SDK [TODO]()

Samples [TODO]()

Docs [TODO]()

Tools [TODO]()

swagatmishra2007 commented 3 years ago

@Jeffders @carlosscastro @stevengum @EricDahlvang thoughts?

daveta commented 3 years ago

Hi @swagatmishra2007, were you able to get any consensus here?

EricDahlvang commented 3 years ago

Looks like a good plan to me.