search

microsoft / botframework-sdk

Bot Framework provides the most comprehensive experience for building conversation applications.
MIT License
7.47k stars 2.44k forks source link

Enable Instrumentation by APM for Deeper Traces #6233

Open TheSecMaven opened 3 years ago

TheSecMaven commented 3 years ago

Is your feature request related to a problem? Please describe. I am trying to understand deeper level use cases, and to do that often use an APM Tool to track performance of pieces of the code. I lack the ability to see how long certain pieces of this library are taking because we have no instrumentation on it, and just adding default APM configs don't see to enable it.

Describe the solution you'd like Would like to see functions called reported to an APM solution so that I can see how long certain pieces of code are taking, and also track a request down to the functions being called.

Describe alternatives you've considered The solution would be vendor agnostic ideally.

Additional context NA

joshgummersall commented 3 years ago

Thanks for the feature request, @mkkeffeler! I'm going to transfer this to the SDK parent project for consideration.

daveta commented 3 years ago

@mkkeffeler : Thanks, do you have specific operations you are looking to time?

TheSecMaven commented 3 years ago

Timing is one thing, on things like validating the authentication token for example, but also seeing what dialog was invoked, and when the userState is stored somewhere (be it a custom backend, or in memory). In our case, we are using https://github.com/mokeddes/botbuilder-storage-redis so they may need an enhancement, but any visibility to the backend would be helpful.