search

microsoft / botframework-sdk

Bot Framework provides the most comprehensive experience for building conversation applications.
MIT License
7.47k stars 2.44k forks source link

Microsoft teams bot is incorrectly being identified as a Skype bot #6580

Closed anesh closed 1 year ago

anesh commented 1 year ago

Version

4.14.1

Describe the bug

I am unable to send messages to a teams bot developed using the Microsoft Botframework SDK using Python, When i investigated i found out while uploading the bots to team as a custom app, during the app validation phase, its treating the app as a skype app, Trace is in below screen shot, This happens only Teams, when tested on Webchat it works without any issues

Looking at the console logs it says conversation id not found, it may be because it using an incorrect API call to start the conversation ??

To Reproduce

Steps to reproduce the behavior:

  1. Zip the manifest.json
  2. Upload to teams as custom app

Expected behavior

I should be able to send message to the bot

Screenshots

screenshot

screenshot_2

Below is the manifest.json used

`` { "$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.14/MicrosoftTeams.schema.json", "manifestVersion": "1.14", "version": "2.2.1", "id": "4722bea3-940c-4a08-9a2c-373fe51c7cb5", "packageName": "com.teams.level1bot", "developer": { "name": "Anesh Kesavan", "websiteUrl": "https://aneshkesavan.com", "privacyUrl": "https://microsoft.com/privacy", "termsOfUseUrl": "https://github.com/microsoft/BotFramework-FunctionalTests/blob/main/LICENSE" }, "icons": { "color": "color.png", "outline": "outline.png" }, "name": { "short": "NetworkBot", "full": "Network Bot for Network Core Services" }, "description": { "short": "Network Bot for network information", "full": "Network Bot for Infoblox, F5, Cisco" }, "accentColor": "#FFFFFF", "bots": [ { "botId": "4722bea3-940c-4a08-9a2c-373fe51c7cb5", "scopes": [ "team", "personal", "groupchat" ], "supportsFiles": false, "isNotificationOnly": false } ], "permissions": [ "identity", "messageTeamMembers" ], "validDomains": [] }

anishprasad01 commented 1 year ago

Hi @anesh,

I am unable to reproduce this issue using the Python Teams Conversation Bot sample.

While my network trace also shows skypetoken, the token is being requested from the teams.microsoft.com authority and is successfully retrieved. The welcome card then appears, and after clicking "Who am I?", the bot is able to identify my user account.

What kind of Azure environment are you using this in? Are there regional cloud or other restrictions on this bot?

anesh commented 1 year ago

@anishprasad01 it started working yesterday, without making changes on my end.