search

microsoft / botframework-solutions

Welcome to the Bot Framework Solutions repository which is the home for a set of templates and solutions to help build advanced conversational experiences using Azure Bot Service and Bot Framework. Microsoft Bot Framework is a comprehensive framework for building enterprise-grade conversational AI experiences.
https://aka.ms/bfsolutionsdocs
MIT License
1.05k stars 530 forks source link

Azure Devops Pipeline failing on Nuget restore with latest bot-solutions package 1.1.0 #3833

Closed tomSauret847 closed 3 years ago

tomSauret847 commented 3 years ago

What project is affected? Virtual Assistant

What language is this in? .net

What happens?

when using the sample here the build pipeline fails with the following error

[error]The nuget command failed with exit code(1) and error(F:\agents_work_tool\dncs\2.2.100\x64\sdk\2.2.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(137,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1. Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.

What are the steps to reproduce this issue?

build new template using latest version use pipeline example that is included in the template push project to Azure Devops and let the build pipeline run

What were you expecting to happen?

The build to succeed and the project is built

Can you share any logs, error output, etc.?

see above error

Any screenshots or additional context?

axelsrz commented 3 years ago

@lauren-mills could you please look into this issue and provide some feedback? thanks

lauren-mills commented 3 years ago

@Batta32 - it seems like the pipeline yaml may need to be updated to support the latest code. Can you take a look?

Batta32 commented 3 years ago

Sure @lauren-mills! We will take a look at this issue as soon as possible.

Thanks @tomSauret847 for reporting this issue, as soon as we have any update, we will back to you here 😊.

Batta32 commented 3 years ago

Hi @tomSauret847, we have planned to work on this issue in the next week.

We will let you know any update 😊.

matiasroldan6 commented 3 years ago

Hi @tomSauret847, we were able to reproduce this. Our setup was:

We got the error saying the .NET SDK does not support targeting .NET Core 3.1, most likely because the .NET Core version specified in the YAML file is 2.2.100 while the current Virtual Assistant project is on .NET Core 3.1. We will work on finding the best approach for updating the YAML. image

hcyang commented 3 years ago

Hi @matiasroldan6 and @Batta32, any update to a solution?

matiasroldan6 commented 3 years ago

Hi @tomSauret847, @hcyang. Sorry about the delay, we found some things out of date in the Virtual Assistant's YAML which we fixed in PR #3835.

You can take this PR -or wait until it is merged- and see if it fixes the issue you have. Let us know of any further issues.

tomSauret847 commented 3 years ago

Thank you @matiasroldan6 for looking into this. I took the PR and updated my project and was able to get the project to build. It is now working as expected.

hcyang commented 3 years ago

Thanks @tomSauret847 for raising the issue and @matiasroldan6 for providing a solution. Closing the issue now.