search

microsoft / build-server-for-gradle

An implementation of the Build Server Protocol for Gradle
MIT License
45 stars 7 forks source link

add message checking to integration tests #136

Closed Arthurm1 closed 2 months ago

Arthurm1 commented 2 months ago

Currently the integration tests only handle direct replies to BSP messages e.g. workspace/buildTargets returns WorkspaceBuildTargetsResult

This PR allows monitoring of async messages e.g. build/taskProgress and adds tests for these.

It's the first step in testing progress reports per build target and eventually diagnostic reports.

It also gets rid of the global Launcher.client which I think is a good thing.

Also fixed: the onBuildTaskProgress notification has a compile-task data kind so data must contain a CompileTask

jdneo commented 2 months ago

Had a quick look and the idea looks good to me.

Could you please resolve the conflict?

Arthurm1 commented 2 months ago

@jdneo Done

Arthurm1 commented 2 months ago

rebased

jdneo commented 2 months ago

Thank you @Arthurm1!