microsoft / build-server-for-gradle

An implementation of the Build Server Protocol for Gradle
MIT License
51 stars 8 forks source link

Reconsider to extend the JvmBuildTarget #68

Open jdneo opened 1 year ago

jdneo commented 1 year ago

Currently the definition of JvmBuildTarget is:

export interface JvmBuildTarget {
  /** Uri representing absolute path to jdk
   * For example: file:///usr/lib/jvm/java-8-openjdk-amd64 */
  javaHome?: URI;

  /** The java version this target is supposed to use.
   * For example: 1.8 */
  javaVersion?: string;
}

We can use javaHome to be the JDK path used to launch the project, and javaVersion to be the version of javaHome.

This implies that it is the server's responsibility to search the proper JDK to launch the Gradle daemon.

Based on that, add following fields:

@testforstephen WDYT?