"Previous", "Next" and "Year" buttons are not adopting High contrast black and white themes properly

microsoft / calculator

Windows Calculator: A simple yet powerful calculator that ships with Windows

MIT License

29.6k stars 5.36k forks source link

"Previous", "Next" and "Year" buttons are not adopting High contrast black and white themes properly #388

Open MicrosoftIssueBot opened 5 years ago

MicrosoftIssueBot commented 5 years ago

Pre-Requisite Turn on High contrast using Settings -> Ease of Access -> High contrast -> High contrast black and white.

Repro Steps

Launch Calculator app.
Navigate to Menu and Select Date calculation.
Select Difference between dates from the combo box.
Navigate to From field and press enter.
Date calendar picker will open
Navigate to Previous, Next and Year buttons.
Observe the issue.

Actual Result Previous, Next and Year buttons are of blue color in High contrast white theme and of Yellow color in high contrast black theme.

Expected Result We should be consistent with the default contorl. Previous, Next and Year buttons should be of black color in High contrast white theme and of white color in high contrast black theme. Buttons should have an outline.

Test Environment OS Version: Windows 10 Build 18351.1 App Name: Calculator App Version: 10.1902.16.0

MicrosoftIssueBot commented 5 years ago

This is your friendly Microsoft Issue Bot. I created this issue automatically as requested by a team member.

Dyn0mike commented 5 years ago

This issue is not reproducible in other Windows.UI.Control based application such as XAML Controls Gallery.

The issue is in our implantation of CalanderDatePicker.

grochocki commented 5 years ago

The issue is in our implantation of CalanderDatePicker.

Yep, we should be using the default control here without any customization. If not, we should update so that we are. Otherwise, I am curious if this bug was fixed in the XAML control, in which case we should wait to address this by taking an SDK update.

rudyhuyn commented 5 years ago

The default style has also some flaws too:

no border around the popup to delimit the popup to the rest of the app
at minimum, year, previous and next should have a border.

rudyhuyn commented 5 years ago

In addition, the calculator should also displays a border around the date:

it's the case of the default style:

grochocki commented 5 years ago

The default style has also some flaws too

I will route this feedback to the controls team, though those flaws should not prevent us from adopting the default style.

In addition, the calculator should also displays a border around the date

One principle I like to think about when making decisions is "deviate with purpose". In this case, I am not sure there is a good reason to not use the default style (border and all).

rudyhuyn commented 5 years ago

I will route this feedback to the controls team, though those flaws should not prevent us from adopting the default style.

Of course! My comment was more a feedback for the XAML theme, there is no reason to not use the default theme in our case.

deviate with purpose

Exactly, you should override the template of a control when it's your last resort, because you will miss all the optimizations and UI improvements provided by more recent OS updates (Fluent added to a lot of controls, ListViewItem really optimized after RS1 (?), etc...).