microsoft / carbon-aware-sdk

Carbon-Aware Core SDK
MIT License
14 stars 9 forks source link

Decouple the IEmissionsDataSource and IForecastDataSource Interface #161

Closed esgraham closed 1 year ago

esgraham commented 2 years ago

Description

As a Carbon Aware Data Source developer, I want to add new data sources that may not have all current SDK functionality - including data sources that have only Emissions data but not Forecast data, so I can plug the data source into the SDK without having to throw a NotImplementedException for functionality that does not exist in the data source.

Data Source Interfaces ADR

Acceptance Criteria

Verify that the following WebAPI routes can be executed and return the expected results:

Verify that the that following CLI routes can be executed and return the expected results:

Dependencies

https://github.com/Green-Software-Foundation/carbon-aware-sdk/issues/170

Task List

Working agreement to delete at little as possible, and just c+p to new classes Need to document for each other if and when we change any ported code.

Sprint-Ready Checklist

esgraham commented 1 year ago

PR: https://github.com/Green-Software-Foundation/carbon-aware-sdk/pull/187

esgraham commented 1 year ago

Merged