search

microsoft / carbon-aware-sdk

Carbon-Aware Core SDK
MIT License
14 stars 8 forks source link

[Bug]: ElectricityMapsDataSource fails with regional settings with comma as decimal separator #227

Closed Lybecker closed 1 year ago

Lybecker commented 1 year ago

Contact Details

anlybeck@microsoft.com

What happened?

Running the CA-SDK with regional settings e.g. Danish that uses comma as decimal separator fails. The HTTP request to ElectricityMaps API urlencodes the comma to %2C

client

WebAPI (Default)

Relevant log output

No response

Code of Conduct

gfmatthews commented 1 year ago

Definitely should fix this. Approving for triage - whomever picks this up, please investigate a fix that would solve this globally (i.e. for any region, not just US English or Danish)

pritipath commented 1 year ago

Merged in GSF