microsoft / cascadia-code

This is a fun, new monospaced font that includes programming ligatures and is designed to enhance the modern look and feel of the Windows Terminal.
Other
26k stars 809 forks source link

powerline glyphs regressed in latest version, do not touch top of cell #310

Open DHowett opened 4 years ago

DHowett commented 4 years ago

This is evident at a very high point size, but it's also visible at 12pt on a 200%-scale display. It does not seem to get better/worse as weight changes.

image

image

Environment

Cascadia Code version number: 2007.01
Application (with version) used to display text: Windows Terminal (DWrite)
OS platform and version: Windows 10
Screen resolution (i.e. 220dpi): 200% scaling, 3000x2000

Any other software?
aaronbell commented 4 years ago

Did y'all modify the text rendering in Windows Terminal at all recently? As far as I can tell, everything is pretty much exactly the same as the previous version that I'd sent you over email—font metrics, PL positioning, rclt feature, etc.

DHowett commented 4 years ago

Unfortunately, we didn't ☹️

I just installed and brought up the two side-by-side in the same WT instance.

image

EDITED: used the wrong char on the right side! Fixed the screenshot.

aaronbell commented 3 years ago

So. Funny story.

It looks like Windows Terminal doesn't turn on rclt in the text entry field, but it does in the output portion of the window:

Capture

I inserted a BIG BLACK BOX into the shading characters as a test, and was surprised to see it show up in the red bits, but not in the Command Line.

So my guess is that the reason why the substitution is not working (and similarly why the sTypo versions are not being used in Powerline) is due to this reason. Soooo, I send this back over to you :)

DHowett commented 3 years ago

That's very concerning, actually. All text in our buffer (input, output) goes through the same handling (because actually, input is invisible until powershell turns it back into output and sends it back to us.).

Huh.

ashencone commented 2 years ago

This also happens with (U+2588) "█" only if the "features" flag is set. bug_wt_cascadia