search

microsoft / cascadia-code

This is a fun, new monospaced font that includes programming ligatures and is designed to enhance the modern look and feel of the Windows Terminal.
Other
25.95k stars 807 forks source link

Fix issues in the Feb update #410

Closed aaronbell closed 3 years ago

aaronbell commented 3 years ago

Summary of the Pull Request

A small set of fixes that resolves a couple of new bugs introduced in the latest version, plus other fixes I have been working on.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Full changelist:

aaronbell commented 3 years ago

Adding a few more updates :)

DHowett commented 3 years ago

@aaronbell this good for release soon? I'm happy to review/sign off and tag it 2102.23 if so :)

aaronbell commented 3 years ago

@DHowett the only other thing that might be worth doing is the postscript name issue I emailed you about a little while ago. Did you have thoughts on that?

aaronbell commented 3 years ago

@DHowett I've submitted another couple of small fixes to resolve the postscript issue and prevent MVAR table generation. Should be good to go.

DHowett commented 3 years ago

Thanks! I'll build this into the next version of Terminal. Unfortunately, I missed the boat for this one by just a hair, so I'll hold back just a little while to avoid breaking people.

I have GOT to get Cascadia out of our package. Good lord.

aaronbell commented 3 years ago

@DHowett It'd probably be good—I think you can set up the packages such that the Windows Terminal one will automatically download a "Cascadia Code" one.

That way we could also put the PL fonts in too, no? Then folks wouldn't have to download them separately!

DHowett commented 3 years ago

@aaronbell whoops, ufolint got real mad about this. I also fixed the PR trigger so it would fail future PRs for linting errors.

2021-02-25T20:00:28.8261060Z Test result that led to failure: 2021-02-25T20:00:28.8365140Z [FAIL] sources/CascadiaCode-Bold.ufo/glyphs.public.background contains rogue files not listed in contents.plist: gheupturn-cy.glif, asciitilde_equal.liga.glif, less_less_equal_start.seq.glif, quotedblbase.glif, g.glif, less_less_equal_middle.seq.glif, parenleft_asterisk.liga.glif, ka-cy.glif, kaiS_ymbol.glif, A_lpha-latin.glif, idotless.glif, dcaron.alt.glif, G_stroke.glif, N_hookleft.glif, greater_greater_hyphen_middle.seq.glif, kappa.glif, numbersign_underscore_parenleft.liga.glif, greater_greater_equal_start.seq.glif, quoteright.glif, nine.glif, quotesinglbase.glif, d.glif, greater_greater_equal_middle.seq.glif, quoteleft.glif, p.glif, greater.center.glif, numbersign_middle.seq.glif, less_less_hyphen_middle.seq.glif, rho.glif, less_less_hyphen_start.seq.glif, greater_greater_hyphen_end.seq.glif, six.glif, onehalf.glif, K_aiS_ymbol.glif, nhookleft.glif, asterisk_parenright.liga.glif, greater_greater_equal_end.seq.glif, less_less_hyphen_end.seq.glif, greater.alt.glif, less_less_equal_end.seq.glif, notedbl-musical.glif, kadescender-cy.glif, degree.glif, dashdownA_rrow.glif, integraltp.glif, integralbt.glif

This seems like a very much not good thing? Are these dead old files that got moved and replaced? I noticed some things got moved out of background into public but didn't know enough to ask.

DHowett commented 3 years ago

I suspect that the files in the background/ directory are outdated and should have been deleted because in the previous update you moved them into the non-background one?

aaronbell commented 3 years ago

Yeah, all those files (and the folders themselves I think) can just be deleted. No background files necessary!

DHowett commented 3 years ago

Whoa, none? The background contents file still refers to one thing: macronbelowcomb.

aaronbell commented 3 years ago

The background files have no impact on the font output. They're just there as extra cruft from my development work. I should really just delete them all on conversion to UFO.

DHowett commented 3 years ago

Mind doing that in a PR? I'm strapped into meetings almost all day ☹️

aaronbell commented 3 years ago

Oh... I merged the fix in :)

DHowett commented 3 years ago

huh, it notified me that your PR was closed (without merging)

aaronbell commented 3 years ago

Oh yeah, I PR'd the wrong thing, so closed it. Ended up just merging in an update directly. :x

aaronbell commented 3 years ago

(https://github.com/microsoft/cascadia-code/commit/d4fac8bb485279aaa6633f7bf00f3b56d2362e08)

DHowett commented 3 years ago

☹️ 

2021-02-25T20:23:08.8372820Z ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-02-25T20:23:08.8418550Z sources/CascadiaCode-Bold.ufo
2021-02-25T20:23:08.8519700Z ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-02-25T20:23:08.8621680Z  
2021-02-25T20:23:08.8723270Z [UFO directory] ....... 
2021-02-25T20:23:08.8819450Z    Found UFO v3
2021-02-25T20:23:08.8841710Z    Detected glyphs directories: 
2021-02-25T20:23:08.8843730Z      -- glyphs . 
2021-02-25T20:23:08.8845470Z      -- glyphs.public.background F
2021-02-25T20:23:08.8846400Z 
2021-02-25T20:23:08.8847740Z =============================================================================
2021-02-25T20:23:08.8849980Z sources/CascadiaCode-Bold.ufo failed ufolint testing! Exit with status code 1
2021-02-25T20:23:08.8851490Z =============================================================================
2021-02-25T20:23:08.8952800Z  
2021-02-25T20:23:08.9017690Z Test result that led to failure:
2021-02-25T20:23:08.9119990Z [FAIL] Unable to find the UFO directory 'glyphs.public.background' defined in layercontents.plist
2021-02-25T20:23:08.9219570Z
aaronbell commented 3 years ago

Well that serves me right.

aaronbell commented 3 years ago

OK. updated again. Double-checked that it builds. :)